Resolve "Backend Refactor: Entities and API DTOs"
I refactored the API and Entities into separate modules, they are now in the $PROJECT_ROOT/fda-metadata-db
folder. Other changes:
- Upgraded Spring Boot Parent 2.3.4 -> 2.3.10.RELEASE on all Java-based services
- Spring Cloud now also SR8.Hoxton -> 3.0.1
- Removed some unnecessary Maven code for dependencymanagement
- Your DTOs and Entities now comply with the Java-standard CamelCase naming convention (no other changes in your code, just renaming)
- All services have either implemented tests or mocks, they all are ready for test implementation
dev
What should be fulfilled to be able to merge into - Please check if the data store works, I did not change very much, but due to the high refactoring it can be the case that some runtime stuff does not work as you intended
Closes #42
Merge request reports
Activity
added scope::Backend status::Doing + 1 deleted label
For me this does not work sadly. I get errors with the docker container, that the manifest is missing and that all services are somehow crashing afterwards, because it could not create the metadata-database is my guess. But now, I do not trust any setup of mine anymore - so it could be an error only for me again.
The two errorcodes I get are (for all depending services):
no main manifest attribute, in ./discovery.jar
ERROR Failed to initialize JPA EntityManagerFactory: [PersistenceUnit: default] Unable to build Hibernate SessionFactory; nested exception is org.hibernate.tool.schema.spi.SchemaManagementException: Schema-validation: missing table [mdb_container]
added 7 commits
- 83faaf8b - all api and entity objects now have a builder, fixed service tests, fixed endpoint tests
- 803553e7 - fixed some container tests
- 1cc31cce - added database test mocks
- 7a29a58a - added some endpoint tests for database service
- 581342c1 - added 30 tests to database service
- d9c7dc59 - require the test db for testing
- eaf9caf5 - compiles on laptop
Toggle commit list
Please register or sign in to reply