Dev

.docs/system-services-metadata.md

@@ -71,6 +71,10 @@ execution to the raw data. Any stale queries (query that have been executed by u
 periodically being deleted from the query store based on the `DELETE_STALE_QUERIES_RATE` environment variable (defaults
 to 60 seconds).
 
+Executing SQL queries through the Query Endpoint must fulfill some restrictions:
+
+* The SQL query does not contain at semicolon `;`
+
 ### Semantics
 
 The service provides metadata to the table columns in the [Metadata Database](../system-databases-metadata) from

.gitlab-ci.yml

@@ -71,6 +71,18 @@ build-docker:
     - "docker build -t dbrepo-data-service:build --target build dbrepo-data-service"
     - "docker compose build --parallel"
 
+build-helm:
+  image: docker.io/docker:24-dind
+  stage: build
+  before_script:
+    - echo "$CI_REGISTRY_PASSWORD" | docker login --username "$CI_REGISTRY_USER" --password-stdin $CI_REGISTRY_URL
+  script:
+    - apk add sed helm curl
+    - 'sed -i -e "s/^version:.*/version: \"${CHART_VERSION}\"/g" ./helm-charts/dbrepo/Chart.yaml'
+    - 'sed -i -e "s/^appVersion:.*/appVersion: \"${APP_VERSION}\"/g" ./helm-charts/dbrepo/Chart.yaml'
+    - find ./helm-charts -type f -exec sed -i -e "s/__CHARTVERSION__/${CHART_VERSION}/g" {} \;
+    - helm package ./helm-charts/dbrepo --destination ./build
+
 test-metadata-service:
   image: maven:3-openjdk-17
   stage: test
@@ -119,12 +131,13 @@ test-analyse-service:
   script:
     - "pip install pipenv"
     - "pipenv install gunicorn && pipenv install --dev --system --deploy"
-    - "cd ./dbrepo-analyse-service/ && coverage run -m pytest test/test_determine_dt.py test/test_determine_pk.py test/test_determine_stats.py --junitxml=report.xml && coverage html && coverage report > ./coverage.txt"
+    - cd ./dbrepo-analyse-service/ && coverage run -m pytest test/test_determine_dt.py test/test_determine_pk.py test/test_s3_client.py --junitxml=report.xml && coverage html --omit="test/*" && coverage report --omit="test/*" > ./coverage.txt
     - "cat ./coverage.txt | grep -o 'TOTAL[^%]*%'"
   artifacts:
     when: always
     paths:
       - ./dbrepo-analyse-service/report.xml
+      - ./dbrepo-analyse-service/coverage.txt
     expire_in: 1 days
     reports:
       junit: ./dbrepo-analyse-service/report.xml

dbrepo-analyse-service/pytest.ini

 [pytest]
 log_cli = 1
 log_level = info
-log_disable = main
\ No newline at end of file

dbrepo-metadata-db/setup-schema.sql

@@ -139,6 +139,7 @@
     versioned             boolean                not null default true,
     created_by            character varying(36)  NOT NULL,
     owned_by              character varying(36)  NOT NULL,
+    processed_constraints BOOLEAN                NOT NULL DEFAULT false,
     last_modified         timestamp,
     PRIMARY KEY (ID),
     FOREIGN KEY (tDBID) REFERENCES mdb_databases (id),
@@ -153,7 +154,6 @@
     dfID             BIGINT,
     cName            VARCHAR(100),
     internal_name    VARCHAR(100) NOT NULL,
-        alias            VARCHAR(100),
     Datatype         ENUM ('CHAR','VARCHAR','BINARY','VARBINARY','TINYBLOB','TINYTEXT','TEXT','BLOB','MEDIUMTEXT','MEDIUMBLOB','LONGTEXT','LONGBLOB','ENUM','SET','BIT','TINYINT','BOOL','SMALLINT','MEDIUMINT','INT','BIGINT','FLOAT','DOUBLE','DECIMAL','DATE','DATETIME','TIMESTAMP','TIME','YEAR'),
     length           BIGINT       NULL,
     ordinal_position INTEGER      NOT NULL,
@@ -220,6 +220,7 @@
     fkid      BIGINT       NOT NULL AUTO_INCREMENT,
     tid       BIGINT       NOT NULL,
     rtid      BIGINT       NOT NULL,
+    name      VARCHAR(255) NOT NULL,
     on_update VARCHAR(50)  NULL,
     on_delete VARCHAR(50)  NULL,
     position  INT          NULL,
@@ -243,6 +244,7 @@
 CREATE TABLE IF NOT EXISTS `mdb_constraints_unique`
 (
     uid      BIGINT       NOT NULL AUTO_INCREMENT,
+    name     VARCHAR(255) NOT NULL,
     tid      BIGINT       NOT NULL,
     position INT          NULL,
     PRIMARY KEY (uid),
@@ -358,7 +360,8 @@
     id               BIGINT NOT NULL AUTO_INCREMENT,
     cid              BIGINT NOT NULL,
     vid              BIGINT NOT NULL,
-        position INTEGER NULL,
+    alias            VARCHAR(100),
+    ordinal_position INTEGER,
     PRIMARY KEY (id),
     FOREIGN KEY (vid) REFERENCES mdb_view (id),
     FOREIGN KEY (cid) REFERENCES mdb_columns (ID)

dbrepo-metadata-service/api/src/main/java/at/tuwien/api/database/query/ImportDto.java

@@ -43,4 +43,8 @@ public class ImportDto {
 
     @Schema(example = "\"")
     private Character quote;
+
+    @JsonProperty("line_termination")
+    @Schema(example = "\\r\\n")
+    private String lineTermination;
 }

dbrepo-metadata-service/api/src/main/java/at/tuwien/api/database/table/constraints/foreignKey/ForeignKeyDto.java

@@ -19,6 +19,8 @@ import java.util.List;
 @ToString
 public class ForeignKeyDto {
 
+    private String name;
+
     @org.springframework.data.annotation.Transient
     private List<ColumnDto> columns;
 

dbrepo-metadata-service/entities/src/main/java/at/tuwien/entities/database/View.java

@@ -111,20 +111,13 @@ public class View {
         return this.internalName.equals(table.getName().replace("`", ""));
     }
 
-    /**
-     * Cascade cannot be CascadeType.PERSIST since columns already exist
-     */
     @ToString.Exclude
-    @ManyToMany(fetch = FetchType.LAZY, cascade = CascadeType.MERGE)
-    @JoinTable(name = "mdb_view_columns",
-            inverseJoinColumns = {
-                    @JoinColumn(name = "cid", referencedColumnName = "id"),
-            },
-            joinColumns = {
-                    @JoinColumn(name = "vid", referencedColumnName = "id"),
+    @OneToMany(fetch = FetchType.LAZY, cascade = {CascadeType.MERGE, CascadeType.PERSIST})
+    @JoinColumns({
+            @JoinColumn(name = "vid", referencedColumnName = "id", updatable = false)
     })
-    @OrderColumn(name = "position")
-    private List<TableColumn> columns;
+    @OrderColumn(name = "ordinalPosition")
+    private List<ViewColumn> columns;
 
     @CreatedDate
     @Column(nullable = false, updatable = false, columnDefinition = "TIMESTAMP default NOW()")

dbrepo-metadata-service/entities/src/main/java/at/tuwien/entities/database/ViewColumn.java

+package at.tuwien.entities.database;
+
+import at.tuwien.entities.database.table.columns.TableColumn;
+import lombok.*;
+import org.hibernate.annotations.GenericGenerator;
+import org.springframework.data.jpa.domain.support.AuditingEntityListener;
+
+import jakarta.persistence.*;
+
+@Data
+@Entity
+@Builder(toBuilder = true)
+@ToString
+@AllArgsConstructor
+@NoArgsConstructor
+@EntityListeners(AuditingEntityListener.class)
+@jakarta.persistence.Table(name = "mdb_view_columns", uniqueConstraints = {
+        @UniqueConstraint(columnNames = {"cid", "vid"})
+})
+public class ViewColumn implements Comparable<ViewColumn> {
+
+    @Id
+    @EqualsAndHashCode.Include
+    @GeneratedValue(generator = "view-columns-sequence")
+    @GenericGenerator(name = "view-columns-sequence", strategy = "increment")
+    @Column(updatable = false, nullable = false)
+    private Long id;
+
+    @Column(updatable = false)
+    private String alias;
+
+    @Column(nullable = false)
+    private Integer ordinalPosition;
+
+    @ToString.Exclude
+    @ManyToOne(fetch = FetchType.LAZY, cascade = {CascadeType.MERGE})
+    @JoinColumns({
+            @JoinColumn(name = "vid", referencedColumnName = "id", updatable = false)
+    })
+    private View view;
+
+    @ToString.Exclude
+    @ManyToOne(fetch = FetchType.LAZY, cascade = {CascadeType.MERGE})
+    @JoinColumns({
+            @JoinColumn(name = "cid", referencedColumnName = "id", updatable = false)
+    })
+    private TableColumn column;
+
+    @Override
+    public int compareTo(ViewColumn tableColumn) {
+        return Integer.compare(this.ordinalPosition, tableColumn.getOrdinalPosition());
+    }
+}

dbrepo-metadata-service/entities/src/main/java/at/tuwien/entities/database/table/Table.java

@@ -132,6 +132,9 @@ public class Table {
     @Column(columnDefinition = "TIMESTAMP")
     private Instant lastModified;
 
+    @Column(name = "processed_constraints", nullable = false)
+    private Boolean processedConstraints;
+
     @Override
     public boolean equals(Object o) {
         if (o == this) {

dbrepo-metadata-service/entities/src/main/java/at/tuwien/entities/database/table/columns/TableColumn.java

@@ -73,7 +73,7 @@ public class TableColumn implements Comparable<TableColumn> {
     @Column
     private Long indexLength;
 
-    @Column
+    @Transient
     private String alias;
 
     @Column(name = "datatype", nullable = false, columnDefinition = "ENUM('CHAR','VARCHAR','BINARY','VARBINARY','TINYBLOB','TINYTEXT','TEXT','BLOB','MEDIUMTEXT','MEDIUMBLOB','LONGTEXT','LONGBLOB','ENUM','SET','BIT','TINYINT','BOOL','SMALLINT','MEDIUMINT','INT','BIGINT','FLOAT','DOUBLE','DECIMAL','DATE','DATETIME','TIMESTAMP','TIME','YEAR')")

dbrepo-metadata-service/entities/src/main/java/at/tuwien/entities/database/table/constraints/foreignKey/ForeignKey.java

@@ -26,6 +26,9 @@ public class ForeignKey {
     @Column(updatable = false, nullable = false)
     private Long fkid;
 
+    @Column(updatable = false, nullable = false)
+    private String name;
+
     @ToString.Exclude
     @org.springframework.data.annotation.Transient
     @ManyToOne(fetch = FetchType.LAZY, cascade = CascadeType.MERGE)

dbrepo-metadata-service/entities/src/main/java/at/tuwien/entities/database/table/constraints/unique/Unique.java

@@ -27,6 +27,9 @@ public class Unique {
     @Column(updatable = false, nullable = false)
     private Long uid;
 
+    @Column(updatable = false, nullable = false)
+    private String name;
+
     @ToString.Exclude
     @org.springframework.data.annotation.Transient
     @ManyToOne(fetch = FetchType.LAZY, cascade = CascadeType.MERGE)

dbrepo-metadata-service/repositories/src/main/java/at/tuwien/mapper/DatabaseMapper.java

@@ -117,7 +117,7 @@ public interface DatabaseMapper {
     default PreparedStatement databaseToDatabaseMetadata(Connection connection, Database database) throws QueryMalformedException {
         final StringBuilder statement = new StringBuilder("SELECT t.`TABLE_NAME`, t.`TABLE_TYPE`, t.`TABLE_ROWS`, t.`AVG_ROW_LENGTH`, t.`DATA_LENGTH`, t.`MAX_DATA_LENGTH`, COALESCE(t.`CREATE_TIME`, NOW()) as `CREATE_TIME`, t.`UPDATE_TIME`, v.`VIEW_DEFINITION` FROM information_schema.TABLES t LEFT JOIN information_schema.VIEWS v ON t.`TABLE_NAME` = v.`TABLE_NAME` WHERE t.`TABLE_SCHEMA` = '")
                 .append(database.getInternalName())
-                .append("' AND t.`TABLE_TYPE` IN ('BASE TABLE', 'SYSTEM VERSIONED', 'VIEW') AND t.`TABLE_NAME` NOT IN ('qs_queries', '_tmp') AND t.`TABLE_NAME` NOT LIKE 'hs_%' AND t.`TABLE_NAME` NOT LIKE '%_temporary'");
+                .append("' AND t.`TABLE_TYPE` IN ('BASE TABLE', 'SYSTEM VERSIONED', 'VIEW') AND t.`TABLE_NAME` != 'qs_queries' AND t.`TABLE_NAME` NOT LIKE 'hs_%'");
         log.trace("statement={}", statement);
         try {
             return connection.prepareStatement(statement.toString());

dbrepo-metadata-service/repositories/src/main/java/at/tuwien/mapper/TableMapper.java

@@ -85,7 +85,8 @@ public interface TableMapper {
     ColumnTypeDto columnTypeToColumnTypeDto(TableColumnType data);
 
     @Mappings({
-            @Mapping(target = "constraints", ignore = true)
+            @Mapping(target = "constraints", ignore = true),
+            @Mapping(target = "processedConstraints", expression = "java(false)"),
     })
     Table tableCreateDtoToTable(TableCreateDto data);
 
@@ -124,6 +125,7 @@ public interface TableMapper {
     default Unique columnNameListToUnique(Table table, List<String> names) throws TableMalformedException {
         return Unique.builder()
                 .table(table)
+                .name("UK_" + String.join("_", names))
                 .columns(columnNameListToTableColumn(table, names))
                 .build();
     }
@@ -131,7 +133,7 @@ public interface TableMapper {
     ReferenceType referenceTypeDtoToReferenceType(ReferenceTypeDto dto);
 
     @Transactional(readOnly = true)
-    default ForeignKey foreignKeyCreateDtoToForeignKey(Table table, ForeignKeyCreateDto data) throws TableMalformedException {
+    default ForeignKey foreignKeyCreateDtoToForeignKey(Table table, ForeignKeyCreateDto data, Integer index) throws TableMalformedException {
         final String referencedTableInternalName = nameToInternalName(data.getReferencedTable());
         final Optional<Table> optional = table.getDatabase()
                 .getTables()
@@ -142,11 +144,13 @@ public interface TableMapper {
             log.error("Failed to find referenced table with internal name {} in database with id {}", referencedTableInternalName, table.getDatabase().getId());
             throw new TableMalformedException("Failed to find referenced table with internal name " + referencedTableInternalName + " in database with id " + table.getDatabase().getId());
         }
-        final ForeignKey.ForeignKeyBuilder builder = ForeignKey.builder()
+        final ForeignKey foreignKey = ForeignKey.builder()
+                .name("fk_" + table.getInternalName() + "_" + (index + 1))
                 .table(table)
                 .onUpdate(referenceTypeDtoToReferenceType(data.getOnUpdate()))
                 .onDelete(referenceTypeDtoToReferenceType(data.getOnDelete()))
-                .referencedTable(optional.get());
+                .referencedTable(optional.get())
+                .build();
         final List<TableColumn> columns = columnNameListToTableColumn(table, data.getColumns());
         final List<TableColumn> referencedColumns = columnNameListToTableColumn(optional.get(), data.getReferencedColumns());
         if (columns.isEmpty()) {
@@ -158,7 +162,7 @@ public interface TableMapper {
             throw new TableMalformedException("There have to be equally as many columns and referenced columns in a foreign key");
         }
         final List<ForeignKeyReference> references = new ArrayList<>();
-        final ForeignKey foreignKey = builder.references(references).build();
+        foreignKey.setReferences(references);
         for (int i = 0; i < columns.size(); i++) {
             TableColumn column = columns.get(i);
             TableColumn referencedColumn = referencedColumns.get(i);
@@ -177,44 +181,43 @@ public interface TableMapper {
         if (data == null) {
             return null;
         }
-
-        ForeignKeyDto dto = new ForeignKeyDto(
-                new ArrayList<>(),
-                tableToTableBriefDto(data.getReferencedTable()),
-                new ArrayList<>(),
-                referenceTypeDtoToReferenceType(data.getOnUpdate()),
-                referenceTypeDtoToReferenceType(data.getOnDelete())
-        );
-
+        final ForeignKeyDto foreignKey = ForeignKeyDto.builder()
+                .name(data.getName())
+                .columns(new LinkedList<>())
+                .referencedColumns(new LinkedList<>())
+                .referencedTable(tableToTableBriefDto(data.getReferencedTable()))
+                .onDelete(referenceTypeDtoToReferenceType(data.getOnDelete()))
+                .onUpdate(referenceTypeDtoToReferenceType(data.getOnUpdate()))
+                .build();
         for (ForeignKeyReference reference : data.getReferences()) {
-            dto.getColumns().add(tableColumnToColumnDto(reference.getColumn()));
-            dto.getReferencedColumns().add(tableColumnToColumnDto(reference.getReferencedColumn()));
+            foreignKey.getColumns().add(tableColumnToColumnDto(reference.getColumn()));
+            foreignKey.getReferencedColumns().add(tableColumnToColumnDto(reference.getReferencedColumn()));
         }
 
-        return dto;
+        return foreignKey;
     }
 
+    @Transactional(readOnly = true)
     default Constraints constraintsCreateDtoToConstraints(Table table, ConstraintsCreateDto data)
             throws TableMalformedException {
         if (data == null) {
             return null;
         }
-        Constraints.ConstraintsBuilder builder = Constraints.builder();
+        final Constraints.ConstraintsBuilder builder = Constraints.builder();
         if (data.getUniques() != null) {
-            List<Unique> uniques = new ArrayList<>();
+            final List<Unique> uniques = new ArrayList<>();
             for (List<String> columns : data.getUniques()) {
                 uniques.add(columnNameListToUnique(table, columns));
             }
             builder.uniques(uniques);
         }
         if (data.getForeignKeys() != null) {
-            List<ForeignKey> foreignKeys = new ArrayList<>();
-            for (ForeignKeyCreateDto foreignKeyData : data.getForeignKeys()) {
-                foreignKeys.add(foreignKeyCreateDtoToForeignKey(table, foreignKeyData));
+            final List<ForeignKey> foreignKeys = new ArrayList<>();
+            for (int i = 0; i < data.getForeignKeys().size(); i++) {
+                foreignKeys.add(foreignKeyCreateDtoToForeignKey(table, data.getForeignKeys().get(i), i));
             }
             builder.foreignKeys(foreignKeys);
         }
-
         return builder.build();
     }
 
@@ -481,7 +484,7 @@ public interface TableMapper {
     }
 
     default PreparedStatement tableToCreateHistoryViewRawQuery(Connection connection, Table data) throws QueryMalformedException {
-        final StringBuilder view = new StringBuilder("CREATE VIEW `hs_")
+        final StringBuilder view = new StringBuilder("CREATE VIEW IF NOT EXISTS `hs_")
                 .append(data.getInternalName())
                 .append("` AS SELECT * FROM (SELECT ROW_START AS inserted_at, IF(ROW_END > NOW(), NULL, ROW_END) AS deleted_at, COUNT(*) as total FROM `")
                 .append(data.getInternalName())
@@ -588,7 +591,10 @@ public interface TableMapper {
                     .name(resultSet.getString(10))
                     .internalName(resultSet.getString(10))
                     .build();
-            if (resultSet.getString(5) != null) {
+            /* fix boolean and set size for others */
+            if (resultSet.getString(8).equalsIgnoreCase("tinyint(1)")) {
+                column.setColumnType(TableColumnType.BOOL);
+            } else if (resultSet.getString(5) != null) {
                 column.setSize(resultSet.getLong(5));
             } else if (resultSet.getString(6) != null) {
                 column.setSize(resultSet.getLong(6));

dbrepo-metadata-service/repositories/src/main/java/at/tuwien/mapper/ViewMapper.java

@@ -4,16 +4,20 @@ import at.tuwien.api.database.ViewBriefDto;
 import at.tuwien.api.database.ViewCreateDto;
 import at.tuwien.api.database.ViewDto;
 import at.tuwien.entities.database.View;
+import at.tuwien.entities.database.ViewColumn;
+import at.tuwien.entities.database.table.columns.TableColumn;
 import at.tuwien.exception.QueryMalformedException;
 import org.mapstruct.Mapper;
 import org.mapstruct.Mapping;
 import org.mapstruct.Mappings;
 import org.mapstruct.Named;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.sql.Connection;
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
 import java.text.Normalizer;
+import java.util.List;
 import java.util.Locale;
 import java.util.regex.Pattern;
 
@@ -45,15 +49,34 @@ public interface ViewMapper {
 
     ViewBriefDto viewToViewBriefDto(View data);
 
+    @Transactional(readOnly = true)
+    default TableColumn viewColumnToTableColumn(ViewColumn data) {
+        return data.getColumn()
+                .toBuilder()
+                .alias(data.getAlias())
+                .build();
+    }
+
+    default List<ViewColumn> tableColumnsToViewColumns(View view, List<TableColumn> data) {
+        final int[] idx = new int[]{0};
+        return data.stream()
+                .map(c -> ViewColumn.builder()
+                        .ordinalPosition(idx[0]++)
+                        .column(c)
+                        .view(view)
+                        .alias(c.getAlias())
+                        .build())
+                .toList();
+    }
 
     default PreparedStatement viewToSelectAll(Connection connection, View view, Long page, Long size) throws QueryMalformedException {
-        log.debug("mapping view query, view.query={}", view.getQuery());
+        log.debug("mapping view query, view.query={}, page={}, size={}", view.getQuery(), page, size);
         final StringBuilder statement = new StringBuilder("SELECT ");
         final int[] idx = new int[]{0};
         view.getColumns()
                 .forEach(c -> statement.append(idx[0]++ > 0 ? "," : "")
                         .append("`")
-                        .append(c.getInternalName())
+                        .append(c.getAlias() != null ? c.getAlias() : c.getColumn().getInternalName())
                         .append("`"));
         statement.append(" FROM `")
                 .append(view.getInternalName())

dbrepo-metadata-service/rest-service/src/main/java/at/tuwien/endpoints/TableColumnEndpoint.java

@@ -6,7 +6,7 @@ import at.tuwien.api.error.ApiErrorDto;
 import at.tuwien.entities.database.table.columns.TableColumn;
 import at.tuwien.exception.*;
 import at.tuwien.mapper.TableMapper;
-import at.tuwien.service.TableService;
+import at.tuwien.service.TableColumnService;
 import at.tuwien.utils.PrincipalUtil;
 import at.tuwien.utils.UserUtil;
 import at.tuwien.validation.EndpointValidator;
@@ -35,14 +35,15 @@ import java.security.Principal;
 public class TableColumnEndpoint {
 
     private final TableMapper tableMapper;
-    private final TableService tableService;
     private final EndpointValidator endpointValidator;
+    private final TableColumnService tableColumnService;
 
     @Autowired
-    public TableColumnEndpoint(TableMapper tableMapper, TableService tableService, EndpointValidator endpointValidator) {
+    public TableColumnEndpoint(TableMapper tableMapper, EndpointValidator endpointValidator,
+                               TableColumnService tableColumnService) {
         this.tableMapper = tableMapper;
-        this.tableService = tableService;
         this.endpointValidator = endpointValidator;
+        this.tableColumnService = tableColumnService;
     }
 
     @PutMapping
@@ -76,8 +77,7 @@ public class TableColumnEndpoint {
                                             @NotNull @PathVariable("tableId") Long tableId,
                                             @NotNull @PathVariable("columnId") Long columnId,
                                             @NotNull @Valid @RequestBody ColumnSemanticsUpdateDto updateDto,
-                                            @NotNull Principal principal,
-                                            @NotNull @RequestHeader("Authorization") String authorization)
+                                            @NotNull Principal principal)
             throws TableNotFoundException, TableMalformedException, DatabaseNotFoundException, NotAllowedException,
             AccessDeniedException {
         log.debug("endpoint update table, id={}, tableId={}, columnId={}, {}", id, tableId, columnId, PrincipalUtil.formatForDebug(principal));
@@ -85,11 +85,12 @@ public class TableColumnEndpoint {
             endpointValidator.validateOnlyAccess(id, principal, true);
             endpointValidator.validateOnlyOwnerOrWriteAll(id, tableId, principal);
         }
-        final TableColumn column = tableService.update(id, tableId, columnId, updateDto, authorization);
+        final TableColumn column = tableColumnService.update(id, tableId, columnId, updateDto);
         log.info("Updated table semantics of table with id {} and database with id {}", tableId, id);
-        final ColumnDto dto = tableMapper.tableColumnToColumnDto(column);
+        final ColumnDto columnDto = tableMapper.tableColumnToColumnDto(column);
+        log.trace("find table data resulted in column {}", columnDto);
         return ResponseEntity.accepted()
-                .body(dto);
+                .body(columnDto);
     }
 
 }

dbrepo-metadata-service/rest-service/src/main/java/at/tuwien/endpoints/TableDataEndpoint.java

@@ -14,7 +14,6 @@ import at.tuwien.utils.PrincipalUtil;
 import at.tuwien.utils.UserUtil;
 import at.tuwien.validation.EndpointValidator;
 import io.micrometer.observation.annotation.Observed;
-import io.swagger.v3.oas.annotations.ExternalDocumentation;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.media.Content;
 import io.swagger.v3.oas.annotations.media.Schema;
@@ -174,6 +173,14 @@ public class TableDataEndpoint {
         log.debug("endpoint insert data from csv, databaseId={}, tableId={}, data={}, {}", databaseId, tableId, data, PrincipalUtil.formatForDebug(principal));
         /* check */
         endpointValidator.validateOnlyWriteOwnOrWriteAllAccess(databaseId, tableId, principal);
+        if (data.getNullElement() == null) {
+            log.debug("null element not present, default to empty string");
+            data.setNullElement("");
+        }
+        if (data.getLineTermination() == null) {
+            log.debug("line termination not present, default to \\r\\n");
+            data.setLineTermination("\r\n");
+        }
         /* insert */
         queryService.insert(databaseId, tableId, data, principal);
         return ResponseEntity.accepted()
@@ -229,6 +236,15 @@ public class TableDataEndpoint {
             log.error("Failed to view table data: database with id {} is private and user has no authority", databaseId);
             throw new NotAllowedException("Failed to view table data: database with id " + databaseId + " is private and user has no authority");
         }
+        /* default */
+        if (page == null) {
+            log.trace("page is null: default to 0");
+            page = 0L;
+        }
+        if (size == null) {
+            log.trace("size is null: default to 10");
+            size = 10L;
+        }
         /* find */
         final QueryResultDto response = queryService.tableFindAll(databaseId, tableId, timestamp, page, size, principal);
         log.trace("find table data resulted in result {}", response);

dbrepo-metadata-service/rest-service/src/main/java/at/tuwien/endpoints/ViewEndpoint.java

@@ -294,6 +294,15 @@ public class ViewEndpoint {
                 throw new NotAllowedException("Failed to view data of private view: role missing");
             }
         }
+        /* default */
+        if (page == null) {
+            log.trace("page is null: default to 0");
+            page = 0L;
+        }
+        if (size == null) {
+            log.trace("size is null: default to 10");
+            size = 10L;
+        }
         /* find */
         log.debug("find view data for database with id {}", databaseId);
         final View view = viewService.findById(databaseId, viewId, principal);

dbrepo-metadata-service/rest-service/src/main/resources/application-local.yml

@@ -40,7 +40,7 @@ spring:
     loadbalancer.ribbon.enabled: false
 management.endpoints.web.exposure.include: health,info,prometheus
 server:
-  port: 19099
+  port: 9099
 logging:
   pattern.console: "%d %highlight(%-5level) %msg%n"
   level: