From d9f274bf5db1faa2649b30ac186c9d8b21cab7f1 Mon Sep 17 00:00:00 2001
From: Philipp Stadler <a51820432@unet.univie.ac.at>
Date: Wed, 29 May 2024 10:56:42 +0200
Subject: [PATCH] =?UTF-8?q?fix:=20verhindere=20Layout-Spr=C3=BCnge=20nachd?=
=?UTF-8?q?em=20Zeichen=20geladen=20sind?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Wenn die Rückseite einer Karte geladen wird, hüpft das Layout jetzt bei kürzeren Texten nicht mehr. Platz für eine Zeile an Zeichen wird jetzt im Vorhinein reserviert.
Closes #332
---
src/components/write/write.css | 9 +++++++++
src/components/write/write.ts | 5 ++---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/components/write/write.css b/src/components/write/write.css
index ee53e1d..3221f31 100644
--- a/src/components/write/write.css
+++ b/src/components/write/write.css
@@ -1,3 +1,12 @@
+.strichfolge-animation {
+ min-height: 85px;
+ font-size: 0;
+}
+
+.strichfolge-animation.is-large {
+ min-height: 140px;
+}
+
.writers {
/** Don't show spaces */
font-size: 0;
diff --git a/src/components/write/write.ts b/src/components/write/write.ts
index 13be8d6..6737d20 100644
--- a/src/components/write/write.ts
+++ b/src/components/write/write.ts
@@ -11,7 +11,6 @@ import { type GetHanziDataKind, getHanziData } from '../hanzi-data'
import { isMaybeHanzi } from '../is-hanzi'
import { error } from '../debug/log'
-const globalId = 'strichfolge-animation'
/** Pause between strokes */
const delayBetweenStrokes = 300
/**
@@ -107,8 +106,8 @@ interface Writer {
export async function createWriter (userOpts: WriterOpts): Promise<void> {
const opts = { ...writerOptsDefaults, ...userOpts }
const container = opts.addTo
- if (!(container instanceof Element)) {
- throw new Error(`Could not find element #${globalId} for the Hanz writer`)
+ if (!(container instanceof HTMLElement)) {
+ throw new Error(`#${container.outerHTML} is not a HTMLElement`)
}
const writersContainer = document.createElement('div')
writersContainer.classList.add('writers')
--
GitLab