diff --git a/Source/Python/Mods/checks.py b/Source/Python/Mods/checks.py index e9bc5e01d57c2cc452df443789b4b0c65670da9f..5e0c65c3d6f13131d390ffbba6f70b49c999fd3c 100644 --- a/Source/Python/Mods/checks.py +++ b/Source/Python/Mods/checks.py @@ -478,12 +478,17 @@ def check_queue(queue, gateway, destination, ecuid, ecgid): ''' if queue in _config.QUEUES_LIST and \ - (not gateway or not destination or - not ecuid or not ecgid): - raise ValueError('\nEnvironment variables GATEWAY, DESTINATION, ECUID ' + (not ecuid or not ecgid): + raise ValueError('\nEnvironment variables ECUID ' 'and ECGID were not set properly! \n ' 'Please check for existence of file "ECMWF_ENV" ' 'in the run directory!') + elif queue in _config.QUEUES_LIST and \ + (not gateway or not destination): + print('WARNING: Parameters GATEWAY and DESTINATION were ' + 'not properly set for working on ECMWF server. \n' + 'There will be no transfer of output files to the ' + 'local gateway server possible!') return def check_pathes(idir, odir, fpdir, fedir): diff --git a/Source/Python/install.py b/Source/Python/install.py index 9a3e17adf352145760d56e69c5fa4b678223498f..2ed782b2636344fb930ebdc98ca9d4fa8c3c79ca 100755 --- a/Source/Python/install.py +++ b/Source/Python/install.py @@ -284,19 +284,19 @@ def check_install_conditions(c): sys.exit(1) if c.install_target and c.install_target != 'local': - if not c.ecgid or not c.ecuid or \ - not c.gateway or not c.destination: - print('Please enter your ECMWF user id and group id as well ' + - 'as the \nname of the local gateway and the ectrans ' + - 'destination ') - print('with command line options --ecuid --ecgid \ - --gateway --destination') + if not c.ecgid or not c.ecuid: + print('Please enter your ECMWF user id and group id ' + ' with command line options --ecuid --ecgid') print('Try "' + sys.argv[0].split('/')[-1] + \ ' -h" to print usage information') - print('Please consult ecaccess documentation or ECMWF user \ - support for further details') + print('Please consult ecaccess documentation or ECMWF user ' + 'support for further details.\n') sys.exit(1) - + if not c.gateway or not c.destination: + print('WARNING: Parameters GATEWAY and DESTINATION were ' + 'not properly set for working on ECMWF server. \n' + 'There will be no transfer of output files to the ' + 'local gateway server possible!') if not c.installdir: c.installdir = '${HOME}' else: # local diff --git a/setup.sh b/setup.sh index 5adc7ad9ad20bf0996afdd9f5ebd97c69606bed1..ba5069a4717b38b7c487baaef9ddd3bc0769ba8e 100755 --- a/setup.sh +++ b/setup.sh @@ -30,7 +30,7 @@ MAKEFILE='makefile_ecgate' ECUID='<username>' ECGID='<groupID>' GATEWAY='<gatewayname>' -DESTINATION='<name>@genericSftp' +DESTINATION='<username>@genericSftp' INSTALLDIR=None JOB_TEMPLATE='' CONTROLFILE='CONTROL_EA5' @@ -58,13 +58,16 @@ fi # CHECK FOR MORE PARAMETER if [ "$TARGET" == "ecgate" ] || [ "$TARGET" == "cca" ]; then # check if necessary Parameters are set - if [ -z "$ECUID" ] || [ -z "$ECGID" ] || [ -z "$GATEWAY" ] || [ -z "$DESTINATION" ]; then - echo "ERROR: At least one of the following parameters are not set: ECUID, ECGID, GATEWAY, DESTINATION!" + if [ -z "$ECUID" ] || [ -z "$ECGID" ] || [ "$ECUID" == "<username>" ] || [ "$ECGID" == "<groupID>" ] ; then + echo "ERROR: At least one of the following parameters are not properly set: ECUID or ECGID!" echo "EXIT WITH ERROR" exit else parameterlist+=" --ecuid=$ECUID --ecgid=$ECGID --gateway=$GATEWAY --destination=$DESTINATION" fi + if [ -z "$GATEWAY" ] || [ -z "$DESTINATION" ] || [ "$GATEWAY" == "<gatewayname>" ] || [ "$DESTINATION" == "<username>@genericSftp" ] ; then + echo "WARNING: Not setting parameters GATEWAY and DESTINATION means there will be no file transfer to local gateway server." + fi fi if [ -n "$MAKEFILE" ]; then parameterlist+=" --makefile=$MAKEFILE"