diff --git a/fda-database-service/services/src/main/java/at/tuwien/service/DatabaseService.java b/fda-database-service/services/src/main/java/at/tuwien/service/DatabaseService.java index 83ad7a6ae02d9ce311663ee350f630fc0632b1a0..39e913d1be865788f6fb3c1084c3e142fcf36630 100644 --- a/fda-database-service/services/src/main/java/at/tuwien/service/DatabaseService.java +++ b/fda-database-service/services/src/main/java/at/tuwien/service/DatabaseService.java @@ -11,6 +11,7 @@ import lombok.extern.log4j.Log4j2; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; +import javax.transaction.Transactional; import java.util.List; import java.util.Optional; @@ -79,6 +80,7 @@ public class DatabaseService { databaseRepository.deleteById(databaseId); } + @Transactional public Database create(DatabaseCreateDto createDto) throws ImageNotSupportedException, DatabaseConnectionException, DatabaseMalformedException, ContainerNotFoundException { log.debug("get container {}", createDto.getContainerId()); diff --git a/fda-database-service/services/src/main/java/at/tuwien/service/PostgresService.java b/fda-database-service/services/src/main/java/at/tuwien/service/PostgresService.java index c77fc7605b248284180d3482866fe482f3dc7b74..5021469f79244c9a19a94349d183f6afb5ea471b 100644 --- a/fda-database-service/services/src/main/java/at/tuwien/service/PostgresService.java +++ b/fda-database-service/services/src/main/java/at/tuwien/service/PostgresService.java @@ -31,14 +31,14 @@ public class PostgresService extends JdbcConnector { try { connection = open(URL, postgresProperties); } catch (SQLException e) { - log.error("Could not connect to the database container, is it running from Docker container? IT DOES NOT WORK FROM IDE! URL: {} Params: {}", URL, postgresProperties); + log.error("Could not connect to the database container, is it running from Docker container? URL: {} Params: {}", URL, postgresProperties); throw new DatabaseConnectionException("Could not connect to the database container, is it running?", e); } try { final PreparedStatement statement = getCreateDatabaseStatement(connection, database); statement.execute(); } catch (SQLException e) { - log.error("The SQL statement seems to contain invalid syntax"); + log.error("The SQL statement seems to contain invalid syntax or database already exists"); throw new DatabaseMalformedException("The SQL statement seems to contain invalid syntax", e); } } @@ -51,14 +51,14 @@ public class PostgresService extends JdbcConnector { try { connection = open(URL, postgresProperties); } catch (SQLException e) { - log.error("Could not connect to the database container, is it running from Docker container? IT DOES NOT WORK FROM IDE! URL: {} Params: {}", URL, postgresProperties); + log.error("Could not connect to the database container, is it running from Docker container? URL: {} Params: {}", URL, postgresProperties); throw new DatabaseConnectionException("Could not connect to the database container, is it running?", e); } try { final PreparedStatement statement = getDeleteDatabaseStatement(connection, database); statement.execute(); } catch (SQLException e) { - log.error("The SQL statement seems to contain invalid syntax or already exists"); + log.error("The SQL statement seems to contain invalid syntax or database does not exist"); throw new DatabaseMalformedException("The SQL statement seems to contain invalid syntax or already exists", e); } }