From c39d8c828ba7c4a8ad9d3cb7bdf3e42f2da0e904 Mon Sep 17 00:00:00 2001 From: Martin Weise <martin.weise@tuwien.ac.at> Date: Thu, 17 Nov 2022 17:39:15 +0100 Subject: [PATCH] Modify the image environment --- .../src/test/java/at/tuwien/BaseUnitTest.java | 1 - .../service/ContainerServiceIntegrationTest.java | 6 ++++++ .../tuwien/service/ImageServiceIntegrationTest.java | 13 +++++++++++-- .../ContainerImageEnvironmentItemRepository.java | 10 ++++++++++ 4 files changed, 27 insertions(+), 3 deletions(-) create mode 100644 fda-container-service/services/src/main/java/at/tuwien/repository/jpa/ContainerImageEnvironmentItemRepository.java diff --git a/fda-container-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java b/fda-container-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java index 79202e1277..bca4a20283 100644 --- a/fda-container-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java +++ b/fda-container-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java @@ -144,7 +144,6 @@ public abstract class BaseUnitTest { .driverClass(IMAGE_1_DRIVER) .compiled(IMAGE_1_BUILT) .size(IMAGE_1_SIZE) - .environment(IMAGE_1_ENV) .defaultPort(IMAGE_1_PORT) .build(); diff --git a/fda-container-service/rest-service/src/test/java/at/tuwien/service/ContainerServiceIntegrationTest.java b/fda-container-service/rest-service/src/test/java/at/tuwien/service/ContainerServiceIntegrationTest.java index 9bcaf7b91d..1e519b2602 100644 --- a/fda-container-service/rest-service/src/test/java/at/tuwien/service/ContainerServiceIntegrationTest.java +++ b/fda-container-service/rest-service/src/test/java/at/tuwien/service/ContainerServiceIntegrationTest.java @@ -6,6 +6,7 @@ import at.tuwien.config.DockerUtil; import at.tuwien.config.ReadyConfig; import at.tuwien.entities.container.Container; import at.tuwien.exception.*; +import at.tuwien.repository.jpa.ContainerImageEnvironmentItemRepository; import at.tuwien.repository.jpa.ContainerRepository; import at.tuwien.repository.jpa.ImageRepository; import at.tuwien.repository.jpa.UserRepository; @@ -48,6 +49,9 @@ public class ContainerServiceIntegrationTest extends BaseUnitTest { @Autowired private ImageRepository imageRepository; + @Autowired + private ContainerImageEnvironmentItemRepository containerImageEnvironmentItemRepository; + @Autowired private DockerClient dockerClient; @@ -82,6 +86,8 @@ public class ContainerServiceIntegrationTest extends BaseUnitTest { /* mock data */ userRepository.save(USER_1); imageRepository.save(IMAGE_1); + containerImageEnvironmentItemRepository.saveAll(IMAGE_1_ENV); + IMAGE_1.setEnvironment(IMAGE_1_ENV); } @AfterEach diff --git a/fda-container-service/rest-service/src/test/java/at/tuwien/service/ImageServiceIntegrationTest.java b/fda-container-service/rest-service/src/test/java/at/tuwien/service/ImageServiceIntegrationTest.java index a750619662..fc47914b6a 100644 --- a/fda-container-service/rest-service/src/test/java/at/tuwien/service/ImageServiceIntegrationTest.java +++ b/fda-container-service/rest-service/src/test/java/at/tuwien/service/ImageServiceIntegrationTest.java @@ -4,8 +4,10 @@ import at.tuwien.BaseUnitTest; import at.tuwien.api.container.image.ImageCreateDto; import at.tuwien.config.ReadyConfig; import at.tuwien.exception.*; +import at.tuwien.repository.jpa.ContainerImageEnvironmentItemRepository; import at.tuwien.repository.jpa.ContainerRepository; import at.tuwien.repository.jpa.ImageRepository; +import at.tuwien.repository.jpa.UserRepository; import at.tuwien.service.impl.ImageServiceImpl; import lombok.extern.log4j.Log4j2; import org.apache.http.auth.BasicUserPrincipal; @@ -38,15 +40,22 @@ public class ImageServiceIntegrationTest extends BaseUnitTest { @Autowired private ImageRepository imageRepository; + @Autowired + private UserRepository userRepository; + + @Autowired + private ContainerImageEnvironmentItemRepository containerImageEnvironmentItemRepository; + @Autowired private ContainerRepository containerRepository; @Transactional @BeforeEach public void beforeEach() { + userRepository.save(USER_1); imageRepository.save(IMAGE_1); - log.debug("save container {}", CONTAINER_1); - containerRepository.save(CONTAINER_1); + containerImageEnvironmentItemRepository.saveAll(IMAGE_1_ENV); + IMAGE_1.setEnvironment(IMAGE_1_ENV); } @Test diff --git a/fda-container-service/services/src/main/java/at/tuwien/repository/jpa/ContainerImageEnvironmentItemRepository.java b/fda-container-service/services/src/main/java/at/tuwien/repository/jpa/ContainerImageEnvironmentItemRepository.java new file mode 100644 index 0000000000..aa1504a292 --- /dev/null +++ b/fda-container-service/services/src/main/java/at/tuwien/repository/jpa/ContainerImageEnvironmentItemRepository.java @@ -0,0 +1,10 @@ +package at.tuwien.repository.jpa; + +import at.tuwien.entities.container.image.ContainerImageEnvironmentItem; +import org.springframework.data.jpa.repository.JpaRepository; +import org.springframework.stereotype.Repository; + +@Repository +public interface ContainerImageEnvironmentItemRepository extends JpaRepository<ContainerImageEnvironmentItem, Long> { + +} -- GitLab