From 3f6c7b848b37fc0f80f8d0001d78c775e0d3ebf0 Mon Sep 17 00:00:00 2001 From: Martin Weise <martin.weise@tuwien.ac.at> Date: Mon, 28 Nov 2022 15:54:41 +0100 Subject: [PATCH] Fixed the id composites key --- .../main/java/at/tuwien/entities/container/Container.java | 6 ++++-- .../at/tuwien/entities/container/image/ContainerImage.java | 7 ++----- .../entities/container/image/ContainerImageDate.java | 4 +--- .../container/image/ContainerImageEnvironmentItem.java | 3 +-- .../main/java/at/tuwien/entities/database/Database.java | 2 +- .../src/main/java/at/tuwien/entities/database/View.java | 2 +- .../main/java/at/tuwien/entities/database/table/Table.java | 2 +- .../entities/database/table/columns/TableColumn.java | 2 +- .../database/table/columns/concepts/ColumnConcept.java | 2 +- .../entities/database/table/columns/concepts/Concept.java | 2 +- .../main/java/at/tuwien/entities/identifier/Creator.java | 2 +- .../java/at/tuwien/entities/identifier/Identifier.java | 2 +- .../at/tuwien/entities/identifier/RelatedIdentifier.java | 2 +- .../src/main/java/at/tuwien/entities/user/TimeSecret.java | 2 +- .../src/main/java/at/tuwien/entities/user/Token.java | 2 +- .../src/main/java/at/tuwien/entities/user/User.java | 2 +- .../rest-service/src/test/java/at/tuwien/BaseUnitTest.java | 5 +---- 17 files changed, 21 insertions(+), 28 deletions(-) diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/Container.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/Container.java index 25d86eee19..639213fb30 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/Container.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/Container.java @@ -16,6 +16,8 @@ import javax.persistence.*; import java.time.Instant; import java.util.List; +import com.fasterxml.jackson.annotation.JsonIgnore; + @Data @Entity @Builder @@ -29,8 +31,8 @@ public class Container { @Id @EqualsAndHashCode.Include - @GenericGenerator(name = "native", strategy = "native") - @GeneratedValue(strategy = GenerationType.AUTO, generator = "native") + @GeneratedValue(strategy = GenerationType.AUTO) + @Column(updatable = false, nullable = false) private Long id; @ManyToOne(fetch = FetchType.LAZY, cascade = CascadeType.ALL) diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImage.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImage.java index f6fd50d0fd..084966a15e 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImage.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImage.java @@ -1,10 +1,7 @@ package at.tuwien.entities.container.image; import at.tuwien.entities.container.Container; -import at.tuwien.entities.user.User; -import com.fasterxml.jackson.annotation.JsonIgnore; import lombok.*; -import org.hibernate.annotations.GenericGenerator; import org.springframework.data.annotation.CreatedDate; import org.springframework.data.annotation.LastModifiedDate; import org.springframework.data.jpa.domain.support.AuditingEntityListener; @@ -26,7 +23,7 @@ public class ContainerImage { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) public Long id; @@ -67,7 +64,7 @@ public class ContainerImage { @ToString.Exclude @org.springframework.data.annotation.Transient - @OneToMany(fetch = FetchType.LAZY, cascade = CascadeType.MERGE, mappedBy = "image") + @OneToMany(fetch = FetchType.LAZY, cascade = {CascadeType.DETACH, CascadeType.MERGE}, mappedBy = "image") private List<Container> containers; @Column(nullable = false, updatable = false) diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageDate.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageDate.java index e5624a464a..94079ae737 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageDate.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageDate.java @@ -1,9 +1,7 @@ package at.tuwien.entities.container.image; -import at.tuwien.entities.database.table.columns.TableColumn; import com.fasterxml.jackson.annotation.JsonFormat; import lombok.*; -import org.hibernate.annotations.GenericGenerator; import org.springframework.data.annotation.CreatedDate; import org.springframework.data.jpa.domain.support.AuditingEntityListener; @@ -23,7 +21,7 @@ public class ContainerImageDate { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageEnvironmentItem.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageEnvironmentItem.java index a1abe5acad..3bc8bf68aa 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageEnvironmentItem.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/container/image/ContainerImageEnvironmentItem.java @@ -1,7 +1,6 @@ package at.tuwien.entities.container.image; import lombok.*; -import org.hibernate.annotations.GenericGenerator; import org.springframework.data.annotation.CreatedDate; import org.springframework.data.annotation.LastModifiedDate; import org.springframework.data.jpa.domain.support.AuditingEntityListener; @@ -23,7 +22,7 @@ public class ContainerImageEnvironmentItem { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) public Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/Database.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/Database.java index 41fe84a528..2bd23359fe 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/Database.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/Database.java @@ -32,7 +32,7 @@ public class Database { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/View.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/View.java index ab289dd9d2..8355800a85 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/View.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/View.java @@ -23,7 +23,7 @@ public class View { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/Table.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/Table.java index eff1bce677..c2622873d5 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/Table.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/Table.java @@ -31,7 +31,7 @@ public class Table { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/TableColumn.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/TableColumn.java index f74fb634a5..d88409c754 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/TableColumn.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/TableColumn.java @@ -32,7 +32,7 @@ public class TableColumn implements Comparable<TableColumn> { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/ColumnConcept.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/ColumnConcept.java index 1afdedcd0f..d4ef802180 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/ColumnConcept.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/ColumnConcept.java @@ -24,7 +24,7 @@ public class ColumnConcept implements Serializable { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long cid; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/Concept.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/Concept.java index 00c984934c..d60ae1e378 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/Concept.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/database/table/columns/concepts/Concept.java @@ -23,7 +23,7 @@ public class Concept { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Creator.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Creator.java index b1bd315be0..2458b10c1a 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Creator.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Creator.java @@ -23,7 +23,7 @@ public class Creator { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Identifier.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Identifier.java index 44c3a096e4..ab6cb8d4ed 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Identifier.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/Identifier.java @@ -31,7 +31,7 @@ public class Identifier { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/RelatedIdentifier.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/RelatedIdentifier.java index 280715c956..3f36952fb3 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/RelatedIdentifier.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/identifier/RelatedIdentifier.java @@ -28,7 +28,7 @@ public class RelatedIdentifier { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/TimeSecret.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/TimeSecret.java index 53d71c8cc7..e9d00759a1 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/TimeSecret.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/TimeSecret.java @@ -23,7 +23,7 @@ public class TimeSecret { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/Token.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/Token.java index 241f16e777..ae598e2441 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/Token.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/Token.java @@ -23,7 +23,7 @@ public class Token { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(updatable = false, nullable = false) private Long id; diff --git a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/User.java b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/User.java index eb1f77d74a..3a7ab7e059 100644 --- a/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/User.java +++ b/fda-metadata-db/entities/src/main/java/at/tuwien/entities/user/User.java @@ -25,7 +25,7 @@ public class User { @Id @EqualsAndHashCode.Include - @GeneratedValue(strategy = GenerationType.IDENTITY) + @GeneratedValue(strategy = GenerationType.AUTO) @Column(name = "userid", updatable = false, nullable = false) private Long id; diff --git a/fda-table-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java b/fda-table-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java index 4f33b40ddc..c35080dd14 100644 --- a/fda-table-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java +++ b/fda-table-service/rest-service/src/test/java/at/tuwien/BaseUnitTest.java @@ -3,15 +3,12 @@ package at.tuwien; import at.tuwien.api.database.query.QueryBriefDto; import at.tuwien.api.database.query.QueryDto; import at.tuwien.api.user.UserDto; -import at.tuwien.entities.container.image.ContainerImageDate; +import at.tuwien.entities.container.image.*; import at.tuwien.entities.database.table.columns.concepts.Concept; import at.tuwien.entities.user.RoleType; import at.tuwien.entities.user.User; import at.tuwien.querystore.Query; import at.tuwien.entities.container.Container; -import at.tuwien.entities.container.image.ContainerImage; -import at.tuwien.entities.container.image.ContainerImageEnvironmentItem; -import at.tuwien.entities.container.image.ContainerImageEnvironmentItemType; import at.tuwien.entities.database.Database; import at.tuwien.entities.database.table.Table; import at.tuwien.entities.database.table.columns.TableColumn; -- GitLab