From f528b92e904545f4bdc8e0c4bd73316196573530 Mon Sep 17 00:00:00 2001
From: lkugler <lukas.kugler@gmail.com>
Date: Fri, 31 Mar 2023 12:21:06 +0200
Subject: [PATCH] remove quickfix
---
dartwrf/obsseq.py | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/dartwrf/obsseq.py b/dartwrf/obsseq.py
index a5b0264..9473fb7 100755
--- a/dartwrf/obsseq.py
+++ b/dartwrf/obsseq.py
@@ -80,11 +80,14 @@ class ObsRecord(pd.DataFrame):
"""Return posterior Hx array (n_obs, n_ens)"""
try:
return self._get_model_Hx('posterior')
- except Exception as e:
- # this is useful if we evaluate a 'posterior state'
- # then the variable is called 'prior' while it really is a posterior
- warnings.warn(str(e)+' returning prior from this file instead!')
- return self._get_model_Hx('prior')
+ except KeyError as e:
+ raise # change: not allow this, too unsafe
+ # if posterior is not available, return prior
+ # return self._get_model_Hx('prior')
+ # # this is useful if we evaluate a 'posterior state'
+ # # then the variable is called 'prior' while it really is a posterior
+ # #warnings.warn(str(e)+' returning prior from this file instead!')
+ # return self._get_model_Hx('prior')
def get_truth_Hx(self):
return self['truth'].values
@@ -103,7 +106,7 @@ class ObsRecord(pd.DataFrame):
or a subset of observations (self = self.self[343:348])
"""
if what not in ['prior', 'posterior']:
- raise ValueError
+ raise ValueError(what, 'must be prior or posterior')
# which columns do we need?
keys = self.columns
--
GitLab